search

django-cms / djangocms-admin-style

django CMS Admin Style is a Django Theme tailored to the needs of django CMS.
http://www.django-cms.org/
Other
411 stars 116 forks source link

/*env*/ entry in .gitignore file allows to name a virtual environment directory flexibly and unambiguously #510

Closed erkesado closed 5 months ago

erkesado commented 5 months ago

/env/ entry in .gitignore file is derived from django-cms repository. This allows developers a better flexibility in naming a virtual environment directory. So djangocms-admin-style should also apply it in .gitignore specification.

PS: I'm going to work on an issue in django-admin-style and as a contributor, I want the same flexibility in django-admin-style project too :)

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1428c0d) 100.00% compared to head (cd0bf97) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #510 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 33 33 Branches 3 3 ========================================= Hits 33 33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marksweb commented 5 months ago

Hi @erkesado - rather than adding more specific development things to gitignore, developers can use local or global gitignore files that exist on their machine outside of the repo.

Give this article a read on how you can do this; https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/

This is similar to how django operates; https://github.com/django/django/blob/main/.gitignore

erkesado commented 5 months ago

@marksweb Got it. Thank you.