search

django-cms / djangocms-admin-style

django CMS Admin Style is a Django Theme tailored to the needs of django CMS.
http://www.django-cms.org/
Other
411 stars 116 forks source link

fix: Log out user menu on Django 5.0 #512

Closed erkesado closed 5 months ago

erkesado commented 5 months ago

Fixes #509

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1428c0d) 100.00% compared to head (fa46bb2) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #512 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 33 33 Branches 3 3 ========================================= Hits 33 33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

erkesado commented 5 months ago

@fsbraun I'm glad that it works :D

fsbraun commented 5 months ago

@erkesado Frankly, I was hoping for more common styles between <a> and <button>. Now, that you've done, it seems less transparent to me. Sorry, I was pointing you in the wrong direction. Can you go back one commit to c49ddcb96c7438861c94c58634f7b1aa252578a7 (git reset HEAD~1 && git push --force, I believe)?

erkesado commented 5 months ago

@fsbraun I restored the initial commit