search

django-cms / djangocms-admin-style

django CMS Admin Style is a Django Theme tailored to the needs of django CMS.
http://www.django-cms.org/
Other
411 stars 116 forks source link

chore: Update build system #514

Closed fsbraun closed 5 months ago

fsbraun commented 5 months ago

This PR updates the build system

@erkesando Can you check if you can install from this fix (you can install the fix into your venv using pip install -e git+https://github.com/django-cms/djangocms-admin-style@chore/update-build-system)?

Pending: Update of webpack.config.js.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (89589a8) 100.00% compared to head (4aa3834) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #514 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 33 33 Branches 3 3 ========================================= Hits 33 33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fsbraun commented 5 months ago

Sure! Works nicely.

vinitkumar commented 5 months ago

Sure! Works nicely.

@fsbraun Shouldn't we also commit the built files in the same PR, so is there no diff for them?

fsbraun commented 5 months ago

@vinitkumar Fair point!! Just added them. The JS now uses ()=>{} notation. I.e., there is a change.