django-cms / djangocms-admin-style

django CMS Admin Style is a Django Theme tailored to the needs of django CMS.
http://www.django-cms.org/
Other
411 stars 116 forks source link

fix: history summary #520

Closed raffaellasuardini closed 3 months ago

raffaellasuardini commented 4 months ago

Description

As mentioned in the issue, the left padding in the page history has been updated.

Before:
#change-history .paginator,.change-list table .paginator,.dashboard table .paginator,.results table .paginator,.tabular table .paginator {
    box-shadow: none!important;
}

After:

#change-history .paginator,.change-list table .paginator,.dashboard table .paginator,.results table .paginator,.tabular table .paginator {
    box-shadow: none!important;
    padding-left: 10px;
    box-sizing: border-box;
}
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f1bbc9d) to head (721fc91).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #520 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 33 33 Branches 3 3 ========================================= Hits 33 33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fsbraun commented 3 months ago

@raffaellasuardini Can you rebase your fork and make the change to the corresponding sass file? This is compile into the css. Only changes in the sass files will be persistent.

raffaellasuardini commented 3 months ago

Sure @fsbraun. I'm going to work on it.

fsbraun commented 3 months ago

@raffaellasuardini Can you also run gulp sass to update the css assets?

raffaellasuardini commented 3 months ago

@fsbraun I ran the gulp file but it also created files like.eot .ttfand .woff should I also include them?

fsbraun commented 3 months ago

Yes, please do that. Sometimes updates on the compiler lead to minor changes in the binaries.