search

django-cms / djangocms-admin-style

django CMS Admin Style is a Django Theme tailored to the needs of django CMS.
http://www.django-cms.org/
Other
411 stars 116 forks source link

Fix bug in SASS/CSS that hid picture upload widget in djangocms-blog #523

Closed MacLake closed 4 months ago

MacLake commented 4 months ago

Don’t hide certain divs in form .flex-container.form-multiline

fsbraun commented 4 months ago

Fixes #522

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (7b7e5e5) to head (08d0e86).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #523 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 33 33 Branches 3 3 ========================================= Hits 33 33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fsbraun commented 4 months ago

Quick question: The PR includes regenerated fonts. I am not sure what has changed - maybe it's just an effect of rebuilding with more modern versions of the node toolset. @MacLake Can you confirm, icons work as expected?

fsbraun commented 4 months ago

@MacLake Can you bump the version in djangocms_admin_style/__init__.py to 3.3.1? I would like to release this immediately, since it is a severe usability bug.

MacLake commented 4 months ago

I just performed npx gulp icons sass bundle with node 20.11.1 like mentioned in the docs. The icons on the page overview work all fine. I force-reloaded the page on Firefox to be sure that the new files are loaded.

Shall I check anything else? Or should I delete the generated fonts?

I’ve bumped the version to 3.3.1. I wanted to ask anyway if I should do this.