fix: Remove `get_absolute_url` from both `Alias` and `AliasContent` models - Githubissues

django-cms / djangocms-alias

Other

8 stars 23 forks source link

fix: Remove `get_absolute_url` from both `Alias` and `AliasContent` models #199

Closed fsbraun closed 5 months ago

fsbraun commented 9 months ago

Description

According to the Django docs, get_absolute_url should calculate the canonical URL of an object. I argue that aliases should not have a canonical URL, since

they represent fragments which are not to be offered to the end user independently
all URL returned by the current implementation refer to admin sites, which - by definition - are unreachable for non-staff users.
the "View on site" link in the admin's object tools

Fixes the invalid edit alias URL in the plugin menu (if no alias is available in the current language).

Related resources

188

fsbraun commented 9 months ago

@Aiky30 Preview and edit endpoints are not affected by the PR, of course. And they continue to work.