Closed fscherf closed 5 months ago
@fsbraun Thanks for your review. I applied both requested changes
@fsbraun: Is there anything else that I can do?
@fsbraun: What is the state of this PR? Can it be merged?
@fscherf LGTM! I will give it a test asap and merge afterwards!
So, tests should pass again!
@fscherf I can confirm, that deleting the alias draft does not remove all connected alias plugins. However, I fail to get the new message. Can you point me to where I should be seeing this?
@fsbraun: Ah! It seems, the message is not shown when using djangocms-versioning, because it overrides the delete method.
@fsbraun: It works, but the message does not show up in all cases. Is that enough, or do we need to change plans here?
What's the state of this PR?
Previously,
djangocms_alias.models.AliasContent.delete
deleted all plugins related toAliasContent.alias
, with the same language. Drafts and previously published versions included. This meant that the deletion of a draft resulted in plugins disappearing from published pages.This patch removes the mechanism entirely and instead adds a warning, notifying the user that the last version or translation of a language got deleted.