search

django-cms / djangocms-alias

Other
8 stars 23 forks source link

chore: removed final newline #219

Closed raffaellasuardini closed 6 months ago

raffaellasuardini commented 6 months ago

Updated the editor configurations under Mark's suggestion: 

[*.{scss,js,html}]
max_line_length = 120
indent_style = space
insert_final_newline = false
quote_type = double
marksweb commented 6 months ago

@raffaellasuardini Did you mean to close this? This looks like something we had talked about doing?

raffaellasuardini commented 6 months ago

@marksweb I made the changes but I made it on the wrong branch

marksweb commented 6 months ago

@raffaellasuardini Ah ok, well if you create a PR against the wrong branch, you can change where it's target is. But if you started a branch from the wrong branch and still have the changes from this PR, you can start a new branch and cherry-pick the commits from the original branch onto the correct one.