search

django-cms / djangocms-alias

Other
8 stars 23 forks source link

fix draft deletion bug on Django CMS 4.0.x #233

Closed fscherf closed 4 months ago

fscherf commented 4 months ago

This is a backport of https://github.com/django-cms/djangocms-alias/pull/215 for issue #214

fscherf commented 4 months ago

@joshyu: The Django 4.2 tests seem to break because https://github.com/joshyu/djangocms-versioning/tarball/feat/django-42-compatible#egg=djangocms-versioning from tests/requirements/django_42.txt is not available. Can you fix that on your side?

joshyu commented 4 months ago

@joshyu: The Django 4.2 tests seem to break because https://github.com/joshyu/djangocms-versioning/tarball/feat/django-42-compatible#egg=djangocms-versioning from tests/requirements/django_42.txt is not available. Can you fix that on your side?

@fscherf , please help to update line 10 of tests/requirements/django_42.txt from https://github.com/joshyu/djangocms-versioning/tarball/feat/django-42-compatible#egg=djangocms-versioning to https://github.com/django-cms/djangocms-versioning/tarball/support/django-cms-4.0.x#egg=djangocms-versioning

as my feat branch has been merged into support/django-cms-4.0.x

joshyu commented 4 months ago

Hi @fscherf , LGTM. please merge it.