django-cms / djangocms-alias

Other
8 stars 23 forks source link

Fix: removed 'submit-row' from detach_alias.html #237

Closed albanbochsler closed 3 months ago

albanbochsler commented 3 months ago

Description

The css class submit-row causes a weird behavior while extending the delete_confirmation.html template – resulting in 404 every time a Alias is detached in the structure view.


fsbraun commented 3 months ago

@albanbochsler I need to update the test dependency. Do not worry about failed tests for now.

Adding the submit-row class obviously is a great idea. I am not sure I understand the issue with 404, though.

albanbochsler commented 3 months ago

@albanbochsler I need to update the test dependency. Do not worry about failed tests for now.

Adding the submit-row class obviously is a great idea. I am not sure I understand the issue with 404, though.

Hi @fsbraun, it seems that the submit input needs a additional css class in order to be rendered correctly in the modal footer. I've reverted my changes and added the class deletelink to the submit. What I've meant before is that without the proper indication the submit link will force another dialog rather than closing the modal. As far as I understand the class submit-row is a js selector that sets the buttons in the modal footer and interprets the link classes.