search

django-cms / djangocms-audio

django CMS Audio is a set of plugins for django CMS. That allow you to publish audio files on your site.
https://www.django-cms.org
Other
19 stars 9 forks source link

fix: aldryn config parsing #7

Closed stefanfoulis closed 8 years ago

stefanfoulis commented 8 years ago

The result of clean gets used to display forms as well, so it would end up with a string-ification of the values after clean ("[u'item1', u'item2']") instead of the string with commas.

The new implementation cleans the comma separated items to always have a space after the comma. Conversion to an actual python list happens while generating the settings.

codecov-io commented 8 years ago

Current coverage is 76.08% (diff: 100%)

Merging #7 into master will not change coverage

@@             master         #7   diff @@
==========================================
  Files             5          5          
  Lines           138        138          
  Methods           0          0          
  Messages          0          0          
  Branches         12         12          
==========================================
  Hits            105        105          
  Misses           33         33          
  Partials          0          0

Powered by Codecov. Last update 436c6df...110425c

FinalAngel commented 8 years ago

@stefanfoulis would have to adapt that on the other addons as well. can you make an entry in the changelog?

stefanfoulis commented 8 years ago

@FinalAngel changelog entry added

czpython commented 8 years ago

👍