search

django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 58 forks source link

#101, use proper iconset prefix in ckeditor preview #103

Closed sq9mev closed 3 years ago

FinalAngel commented 4 years ago

@sq9mev this appears to change only the compiled file, could you make the change in the source file?

sq9mev commented 4 years ago

@FinalAngel well, now i see it's build with webpack… unfortunelly i'no not familiar with it… actually i could just modify blindly the source as the change is small, but let me do that right way (using wepback), patch will be provided soon.

codecov-io commented 4 years ago

Codecov Report

Merging #103 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #103   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          68     68           
  Lines        1286   1286           
  Branches       87     87           
=====================================
  Hits         1286   1286

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b93b04...ceee0d7. Read the comment docs.

FinalAngel commented 4 years ago

thank you very much, I'll have a look at it in the next days :)

codecov-commenter commented 3 years ago

Codecov Report

Merging #103 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #103    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           68        68            
  Lines         1286      1465   +179     
  Branches        87       123    +36     
==========================================
+ Hits          1286      1465   +179
Impacted Files Coverage Δ
...gocms_bootstrap4/contrib/bootstrap4_card/models.py 100.00% <0.00%> (ø)
...gocms_bootstrap4/contrib/bootstrap4_grid/models.py 100.00% <0.00%> (ø)
...gocms_bootstrap4/contrib/bootstrap4_link/models.py 100.00% <0.00%> (ø)
...gocms_bootstrap4/contrib/bootstrap4_tabs/models.py 100.00% <0.00%> (ø)
...ocms_bootstrap4/contrib/bootstrap4_badge/models.py 100.00% <0.00%> (ø)
...cms_bootstrap4/contrib/bootstrap4_alerts/models.py 100.00% <0.00%> (ø)
...ms_bootstrap4/contrib/bootstrap4_content/models.py 100.00% <0.00%> (ø)
...ms_bootstrap4/contrib/bootstrap4_picture/models.py 100.00% <0.00%> (ø)
...s_bootstrap4/contrib/bootstrap4_carousel/models.py 100.00% <0.00%> (ø)
...s_bootstrap4/contrib/bootstrap4_collapse/models.py 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a8300c3...ac2c8ad. Read the comment docs.

FinalAngel commented 3 years ago

@sq9mev just got to it and the commit fixes the problem. Thank you!