search

django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 58 forks source link

image alignment is ignored #105

Closed macolo closed 4 years ago

macolo commented 4 years ago

This is because https://github.com/divio/djangocms-bootstrap4/blob/master/djangocms_bootstrap4/contrib/bootstrap4_picture/cms_plugins.py#L38 overrides https://github.com/divio/djangocms-picture/blob/master/djangocms_picture/cms_plugins.py#L62

Downstream issue (closed): https://github.com/divio/djangocms-picture/issues/92

macolo commented 4 years ago

I noticed that this is due to a template customization where a class tag is hardcoded for the image, however instance.attributes_str sets the class tag as well which leads to duplicate class tag. Chrome (or the django CMS javascript logic) then removes the 2nd class tag.

diwash007 commented 1 year ago

@macolo How to get around this issue?