django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 58 forks source link

Columns not getting "col-auto"-class #123

Open snake-soft opened 3 years ago

snake-soft commented 3 years ago

If I write "auto", some other text or nothing in the column size fields in structure mode it's the same behaviour: In the Structure mode the Column is called "Column (auto)" but the html element is not getting the class "col-auto".

The only way i can center column content was to choose "leer" (empty) as column type, what means that the element gets not any col class.

The source of that is the model "Bootstrap4GridColumn" and its method "get_grid_values". The method iterates over all the choices generated at the bottom of bootstrap4_grid.models.py and there are no col-auto entries. Those dynamically generated model fields are Integers and therefore it's not possible to save values like 'auto'.

I would suggest to add a "auto" boolean for each grid size.

crydotsnake commented 3 years ago

Do you still have the issue?

fsbraun commented 2 years ago

@snake-soft I have a proposal for the UI to allow for auto columns here: https://github.com/django-cms/djangocms-bootstrap4/issues/127#issuecomment-1063886226 I'd love to hear your input!