search

django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 58 forks source link

BUGFIX: Add missing copy import #141

Closed crydotsnake closed 2 years ago

crydotsnake commented 2 years ago

Related to this pull request: #138

Because of failing checks, i try to fix the issue: https://github.com/django-cms/djangocms-bootstrap4/runs/4082975004?check_suite_focus=true

codecov-commenter commented 2 years ago

Codecov Report

Merging #141 (1e5527b) into master (cef6a92) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #141   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           71        71           
  Lines         1210      1211    +1     
  Branches        65        65           
=========================================
+ Hits          1210      1211    +1
Impacted Files Coverage Δ
..._bootstrap4/contrib/bootstrap4_link/cms_plugins.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 713c1c8...1e5527b. Read the comment docs.

marksweb commented 2 years ago

@crydotsnake what happened on #138, did the checks not pass or did they not run?

I was using the github app on my phone so checks/actions aren't available.

crydotsnake commented 2 years ago

The checks failed because import copy was missing.