django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.

https://www.django-cms.org/

Other

82 stars 58 forks source link

Support djangocms-static-ace to load ace code editor from static files #156

Closed fsbraun closed 1 year ago

fsbraun commented 1 year ago

Description

This PR allows the code editor ace to be served from static files with the help of djangocms-static-ace.

En passant add color scheme detection for the ace editor (dark mode).

Related resources

Fixes this issue: https://github.com/django-cms/djangocms-frontend/issues/48 .

Checklist

[x] I have opened this pull request against master
[x] I have added or modified the tests when changing logic
[x] I have followed the conventional commits guidelines to add meaningful information into the changelog
[x] I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

codecov[bot] commented 1 year ago

Codecov Report

Merging #156 (4380a4f) into master (ee7bcbc) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           71        71           
  Lines         1211      1214    +3     
  Branches       155       156    +1     
=========================================
+ Hits          1211      1214    +3

Impacted Files	Coverage Δ
...cms_bootstrap4/contrib/bootstrap4_content/forms.py	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

marksweb commented 1 year ago

@fsbraun based on the failing test, this may also need an apps.py to define the default auto field.

fsbraun commented 1 year ago

@marksweb The new migrations seem to be happening for cms 3.9. Not sure, apps.py will help. Probably cms 3.9 needed to have a default auto field defined?!?

fsbraun commented 1 year ago

I now skip the migration test for django cms 3.9. This will probably be an issue for other apps, too.

fsbraun commented 1 year ago

@marksweb If you're fine with this, I'd love to merge it and then #145

marksweb commented 1 year ago

@fsbraun I'll take a look shortly