django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 58 forks source link

fix: django import error #162

Closed src-r-r closed 9 months ago

src-r-r commented 1 year ago

Description

Just a simple PR to fix the import error. Line 5-9 are the "real" changes.

All the other changes you see are just the linter cleaning up the code.

Related resources

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1726033) 98.94% compared to head (f78a1e3) 98.94%.

:exclamation: Current head f78a1e3 differs from pull request most recent head ff85640. Consider uploading reports for the commit ff85640 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #162 +/- ## ======================================= Coverage 98.94% 98.94% ======================================= Files 71 71 Lines 1228 1228 Branches 70 70 ======================================= Hits 1215 1215 Misses 8 8 Partials 5 5 ``` | [Files Changed](https://app.codecov.io/gh/django-cms/djangocms-bootstrap4/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms) | Coverage Δ | | |---|---|---| | [...gocms\_bootstrap4/contrib/bootstrap4\_grid/models.py](https://app.codecov.io/gh/django-cms/djangocms-bootstrap4/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms#diff-ZGphbmdvY21zX2Jvb3RzdHJhcDQvY29udHJpYi9ib290c3RyYXA0X2dyaWQvbW9kZWxzLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

src-r-r commented 11 months ago

Yikes, sorry about that, been stressing out about finding sustainable work so haven't gotten to it. It's super-quiet today so I'll work on it (BTW, if you happen to know of anyone who needs a team lead, feel free to reach out).

brenosss commented 4 months ago

HI, it looks like this change is required to use Django 4.2. Is there a plan to release those changes?