Add 'djangocms_icon' to Installation instructions.

django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.

https://www.django-cms.org/

Other

82 stars 58 forks source link

Add 'djangocms_icon' to Installation instructions. #35

Closed electroniceagle closed 6 years ago

electroniceagle commented 6 years ago

The dependency for djangocms-icon exists in setup.py and it is mentioned in the Configuration section, but 'djangocms_icon' should also be listed in the installation instruction for INSTALLED_APPS.

didierCH commented 6 years ago

Essential!

electroniceagle commented 6 years ago

Just looked back at this didn't realize the checks had failed. I'll rebase, but editing the README.rst wasn't the root cause of the failures.

GaretJax commented 6 years ago

@electroniceagle thank you for the PR!

@FinalAngel this LGTM, and tests should pass once https://github.com/divio/djangocms-bootstrap4/pull/43 and #40 have been merged.