documentation for collapse

django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.

https://www.django-cms.org/

Other

82 stars 58 forks source link

documentation for collapse #36

Closed electroniceagle closed 5 years ago

electroniceagle commented 6 years ago

I'm having difficulty understanding how the collapse behavior works. What is the relationship between the three plugins? I'd be happy to contribute some unit tests and/or examples. Even a screen shot of structure view of a working example would be helpful.

jperns commented 5 years ago

@electroniceagle Did you figure this out?

electroniceagle commented 5 years ago

No, went to tabs temporarily. Not a burning issue.

oliashford commented 5 years ago

I am having the same issue.

Currently I have this setup:

The current behaviour is I click "Show Part 1" and the link itself (Collapse Trigger > Text) animates 'show' then I click again and it animates 'hide'... and is gone.

Would be great to just see a screengrab of a working collapse (even better multiple collapses working as a concertina)

oliashford commented 5 years ago

I was pointed to this change:

https://github.com/divio/djangocms-bootstrap4/pull/20/commits/dee89d8627676b18c4fb731e34cb2797266aab9f

by Daniele Procida

I restored the "container-" and "trigger-" that were removed in both files to resolve the issue. Will submit a fix as soon as i get a chance.

vxsx commented 5 years ago

The issue is resolved, will be released soon

the usage outlined here is correct https://github.com/divio/djangocms-bootstrap4/issues/36#issuecomment-435096415

docs PRs are always welcome