django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 57 forks source link

Carousel-indicators data-slide-to= should use a 0 based index #39

Closed Teriks closed 6 years ago

Teriks commented 6 years ago

The carousel template currently has this for carousel-indicators links:

data-slide-to="{{ forloop.counter }}"

I believe it should be this in order to work correctly:

data-slide-to="{{ forloop.counter0 }}"

The template the way it is now results in data-slide-to starting with 1, and causes clicking on the indicator to instead select the next slide. The first indicator is left un-clickable.