search

django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 58 forks source link

Fix get_plugin_template for plugins with custom template selection support #41

Closed GaretJax closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #41 into master will decrease coverage by 0.1%. The diff coverage is 31.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   66.66%   66.56%   -0.11%     
==========================================
  Files          58       60       +2     
  Lines        1245     1256      +11     
  Branches       94       93       -1     
==========================================
+ Hits          830      836       +6     
- Misses        408      413       +5     
  Partials        7        7
Impacted Files Coverage Δ
..._bootstrap4/contrib/bootstrap4_tabs/cms_plugins.py 0% <ø> (ø) :arrow_up:
...tstrap4/contrib/bootstrap4_carousel/cms_plugins.py 62.79% <ø> (ø) :arrow_up:
...tstrap4_tabs/migrations/0002_auto_20180610_1106.py 0% <0%> (ø)
...gocms_bootstrap4/contrib/bootstrap4_tabs/models.py 0% <0%> (ø) :arrow_up:
...ap4_carousel/migrations/0003_auto_20180610_1102.py 100% <100%> (ø)
djangocms_bootstrap4/helpers.py 57.89% <11.11%> (+2.33%) :arrow_up:
...s_bootstrap4/contrib/bootstrap4_carousel/models.py 56.25% <50%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d2663f...12d10a5. Read the comment docs.

GaretJax commented 6 years ago

@czpython could you take a look please?