search

django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 58 forks source link

Error on carousel template #47

Closed mickaelmarin closed 5 years ago

mickaelmarin commented 5 years ago

Hi,

The pypi version of djangocms_bootstrap4 have and error in default template file "carousel.html"

<ol class="carousel-indicators"> {% for plugin in instance.child_plugin_instances %} <li data-target="#carousel-{{ instance.pk }}" data-slide-to="{{ **forloop.counter** }}" # replace by **forloop.counter0** {% if forloop.first %} class="active"{% endif %}> </li> {% endfor %} </ol> thanks

vxsx commented 5 years ago

Fixed in https://github.com/divio/djangocms-bootstrap4/commit/8d2663f04b23a5c39a2225426f299bd201df82c4

vxsx commented 5 years ago

Released in 1.1.0