django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 58 forks source link

Code block renders as <pre> instead of <pre><code> #54

Closed johnfraney closed 5 years ago

johnfraney commented 5 years ago

Currently the code block WYSIWYG editor plugin renders a code block as <pre> without a nested <code> element.

The Bootstrap 4 documentation uses <pre><code> for multi-line code samples, and MDN and some JS code syntax highlighting plugins (namely Prism) require that code be marked up this way.

Would it be possible to update this plugin to use this behaviour?

filwaitman commented 5 years ago

Fixed in version 1.1.2