search

django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 58 forks source link

Add <code> element inside <pre> in code block #55

Closed johnfraney closed 5 years ago

johnfraney commented 5 years ago

Adds a nested <code> element for the block/pre code plugin for more semantic HTML.

johnfraney commented 5 years ago

Closes #54

codecov-io commented 5 years ago

Codecov Report

Merging #55 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files          63       63           
  Lines        1290     1290           
  Branches       98       98           
=======================================
  Hits          858      858           
  Misses        424      424           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d14854f...647dabc. Read the comment docs.

johnfraney commented 5 years ago

Here's a working example of this change: screenshot from 2018-08-18 13-51-16

filwaitman commented 5 years ago

Hi @johnfraney! Thanks for the PR!

This looks good to me. @kinkerl can you take a look as well?

johnfraney commented 5 years ago

@filwaitman Happy to help!

didierCH commented 4 years ago

@johnfraney thank you for this feature. It's super useful.

johnfraney commented 4 years ago

@didierCH You're welcome. Take care!