search

django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 58 forks source link

Carousel default size changing from template with {% with ... %} tags isn't working #56

Closed wanaryytel closed 5 years ago

wanaryytel commented 5 years ago

In constants.py:

# this is used when no valua is passed in the template via
# {% with 1024 as width and 768 as height %}
CAROUSEL_DEFAULT_SIZE = [1024, 768]

Pretty sure that the template trick isn't working with CMS plugins for some reason. I was getting the default every time.

wanaryytel commented 5 years ago

Disregard this. For the future, if someone has the same issue, then carousel.html for some reason overrides every variable you set in a parent template with the default {% with 1024 as width and 768 as height %}. You need to override the carousel.html template no matter what.