django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 58 forks source link

Fix Plural-Forms of i18n for english language #60

Closed alexbarcelo closed 5 years ago

alexbarcelo commented 5 years ago

It still receives warnings:

$> msgfmt -c .../djangocms-bootstrap4/djangocms_bootstrap4/locale/en/LC_MESSAGES

msgfmt: ./django.po: warning: PO file header fuzzy                                             
                     warning: older versions of msgfmt will give an error on this                          
./django.po:8: warning: header field 'Project-Id-Version' still has the initial default value
./django.po:8: warning: header field 'PO-Revision-Date' still has the initial default value    
./django.po:8: warning: header field 'Last-Translator' still has the initial default value
./django.po:8: warning: header field 'Language-Team' still has the initial default value                                      
./django.po:8: warning: header field 'Language' still has the initial default value                                        

But the critical error (see #58) should be fixed with this.

codecov-io commented 5 years ago

Codecov Report

Merging #60 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files          63       63           
  Lines        1290     1290           
  Branches       98       98           
=======================================
  Hits          858      858           
  Misses        424      424           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d14854f...0c583ca. Read the comment docs.

filwaitman commented 5 years ago

Hi @alexbarcelo! Thanks for the PR!

This looks good to me. @kinkerl can you take a look as well?