Closed alexbarcelo closed 5 years ago
Merging #60 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #60 +/- ##
=======================================
Coverage 66.51% 66.51%
=======================================
Files 63 63
Lines 1290 1290
Branches 98 98
=======================================
Hits 858 858
Misses 424 424
Partials 8 8
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d14854f...0c583ca. Read the comment docs.
Hi @alexbarcelo! Thanks for the PR!
This looks good to me. @kinkerl can you take a look as well?
It still receives warnings:
But the critical error (see #58) should be fixed with this.