search

django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 57 forks source link

Fixed a regression with collapse plugins #66

Closed vxsx closed 5 years ago

vxsx commented 5 years ago

This commit made the ids of trigger and container same https://github.com/divio/djangocms-bootstrap4/pull/20/commits/dee89d8627676b18c4fb731e34cb2797266aab9f

which confused js as to what to show or hide

Fixes #36

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@26614bc). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #66   +/-   ##
=========================================
  Coverage          ?   67.13%           
=========================================
  Files             ?       64           
  Lines             ?     1287           
  Branches          ?       95           
=========================================
  Hits              ?      864           
  Misses            ?      415           
  Partials          ?        8

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26614bc...403eb9c. Read the comment docs.