django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 57 forks source link

Fixes djangocms-picture compatibility issues and removed Django <=1.10 support #68

Closed FinalAngel closed 5 years ago

FinalAngel commented 5 years ago

I'm not sure if abstract = False is required, but I assume it is best practice.

codecov-io commented 5 years ago

Codecov Report

Merging #68 into master will decrease coverage by 0.07%. The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   67.13%   67.05%   -0.08%     
==========================================
  Files          64       64              
  Lines        1287     1290       +3     
  Branches       95       95              
==========================================
+ Hits          864      865       +1     
- Misses        415      416       +1     
- Partials        8        9       +1
Impacted Files Coverage Δ
...trib/bootstrap4_picture/migrations/0001_initial.py 100% <ø> (ø) :arrow_up:
..._bootstrap4/contrib/bootstrap4_utilities/models.py 76% <0%> (ø) :arrow_up:
...ms_bootstrap4/contrib/bootstrap4_picture/models.py 92.85% <100%> (+1.19%) :arrow_up:
...ons/0002_bootstrap4picture_use_responsive_image.py 100% <100%> (ø) :arrow_up:
...gocms_bootstrap4/contrib/bootstrap4_grid/models.py 80% <0%> (-2.5%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39388d6...5b6bad4. Read the comment docs.