search

django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 58 forks source link

grid column dialog: include margin top and margin bottom ui edits #78

Closed woodz- closed 5 years ago

woodz- commented 5 years ago

You provide the margin left and margin right ui edits in the Column dialog. But it feels odd, when there are no edits for margin top and margin bottom. That would make it much more fluent, if one can specify all margins from within this dialog. One (like me) might think, he / she needs to add responsive spacing tags. But that is quite another thing and can lead to confusion.

Up to now one must know the secret of possibly extending the class attribute by the bootstrap's specific names to work around this. Is that your intention?

FinalAngel commented 5 years ago

Hello @woodz- , I assume you want to add the margin/padding class modifiers to it such as mt-1 or pl-3?

woodz- commented 5 years ago

Aloha @FinalAngel: yes indeed. Other samples are: mb-3 mb-md-0. If you are going to provide even padding edits - so much the better! Up to now, just margin (left/right) is present, if nothing is magically hidden...

FinalAngel commented 5 years ago

@woodz- ahoi, the margin left and right classes on the grid column are actually special types just for the grid.

We will not add all variants for the spacing utilities, for that please use attributes. Go to advanced settings, utilities and add the keyword "class" and choose any margin/padding combination to add that you'd wish :)