django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 58 forks source link

No field for alternative text in the image plugin #79

Closed didierCH closed 5 years ago

didierCH commented 5 years ago

In the bootstrap3 images plugin there is a field for the alt-tag (alternative text):

grafik

In the bootstrap4 image plugin this is replaced throug the figcaption element (Legend-Field in the plugin) and a figure element is created when filling that form field: grafik

I searched the web but didn't find some evidence that you should omit the alt-tag if you have a figcaption. The only thing I found is this: https://www.w3.org/TR/2014/REC-html5-20141028/embedded-content-0.html#when-a-text-alternative-is-not-available-at-the-time-of-publication

Could you briefly explain what considerations led to the old tag field being omitted? I now that I can add an alt-tag through the attribute button but don't want to complicate things for my users.

FinalAngel commented 5 years ago

Hello @didierCH, the field was removed as the image itself uses the native alt settings from django Filer. djangocms-picture uses that.

It is better to use the media manager (django-filer) to add metadata to the file itself. Sometimes a custom "alt" is required, for that please use the attributes field. The template takes that into consideration.

didierCH commented 5 years ago

Thank you. This makes sense. Didn't know about the alt setting in django filer.

FinalAngel commented 5 years ago

No worries 👍