django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 58 forks source link

bootstrap4_link undefined icon prefix #83

Closed Saeleas closed 5 years ago

Saeleas commented 5 years ago

I found an issue when using the Link/Button plugin: when I try to set an icon (left or right) the iconpicker works correctly but the preview doesn't show the correct icon. From what I gathered the preview doesn't set a correct icon prefix (it sets it to undefined).

bootstrap4_link-issue

This issue then breaks the plugin when it tries to render the icon after saving. In this case is the djangocms_icon module that crashes because it is trying to find the prefix (which is not set). The djangocms_icon plugin works correctly though.

I am using DjangoCMS 3.6 with Django 1.11.20 and djangocms-bootstrap4 1.3.1

FinalAngel commented 5 years ago

This has been fixed in 1.4.0 :=