search

django-cms / djangocms-bootstrap4

django CMS Bootstrap 4 is a plugin bundle for django CMS providing several components from the popular Bootstrap 4 framework.
https://www.django-cms.org/
Other
82 stars 58 forks source link

Fix for latest djangocms-icon 1.3.0 #89

Closed FinalAngel closed 5 years ago

FinalAngel commented 5 years ago

This fixes https://github.com/divio/djangocms-icon/issues/20

migration was used from https://github.com/divio/djangocms-icon/pull/17/files#diff-2570801ed53664d32d80ad8030e8b004R1

Tests will fail until we release djangocms-icon 1.4.0

codecov-io commented 5 years ago

Codecov Report

Merging #89 into master will decrease coverage by 0.03%. The diff coverage is 65.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   66.97%   66.93%   -0.04%     
==========================================
  Files          65       66       +1     
  Lines        1302     1346      +44     
  Branches       96       96              
==========================================
+ Hits          872      901      +29     
- Misses        421      436      +15     
  Partials        9        9
Impacted Files Coverage Δ
...ngocms_bootstrap4/contrib/bootstrap4_link/forms.py 100% <100%> (ø) :arrow_up:
...ib/bootstrap4_link/migrations/0003_icon_updates.py 63.41% <63.41%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5a67ed...a860fb5. Read the comment docs.