django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.
Other
48 stars 21 forks source link

feat: Use own icon module for icons in the link plugin #113

Closed fsbraun closed 1 year ago

fsbraun commented 1 year ago

This PR allows to also use djangocms-frontend's new icon picker for icons within the link plugin. They used to depend on djangocms-icon.

codecov[bot] commented 1 year ago

Codecov Report

Merging #113 (44e0242) into master (d092cb4) will increase coverage by 0.20%. The diff coverage is 88.46%.

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   86.42%   86.63%   +0.20%     
==========================================
  Files         118      119       +1     
  Lines        3086     3082       -4     
  Branches      334      330       -4     
==========================================
+ Hits         2667     2670       +3     
+ Misses        312      307       -5     
+ Partials      107      105       -2     
Impacted Files Coverage Δ
djangocms_frontend/common/attributes.py 100.00% <ø> (ø)
djangocms_frontend/contrib/icon/fields.py 100.00% <ø> (ø)
...cms_frontend/contrib/icon/frameworks/bootstrap5.py 70.58% <ø> (+12.89%) :arrow_up:
...ms_frontend/contrib/icon/templatetags/icon_tags.py 76.92% <76.92%> (ø)
djangocms_frontend/contrib/icon/conf.py 100.00% <100.00%> (ø)
djangocms_frontend/contrib/icon/forms.py 100.00% <100.00%> (ø)
djangocms_frontend/contrib/link/forms.py 83.21% <100.00%> (+0.94%) :arrow_up:
djangocms_frontend/fields.py 79.36% <100.00%> (-0.94%) :arrow_down:

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.