search

django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.
Other
55 stars 22 forks source link

Float pictures #128

Closed raffael-mnhn closed 12 months ago

raffael-mnhn commented 1 year ago

Is your feature request related to a problem? Please describe. I want to be able to have images float left or right.

Describe the solution you'd like Add an option in the image ui that would allow to easily set the float-(sm,md,lg,xl)-begin and -end classes.

Describe alternatives you've considered Content editor unfriendly alternatives are to add the classes manually.

Additional context Add any other context or screenshots about the feature request here.

baravkareknath commented 1 year ago

Hi raffael-mnhn and fsbraun Is this task completed or not? if not can you assign to me

raffael-mnhn commented 1 year ago

I don't think it's completed. Thanks a lot for taking care!

baravkareknath commented 1 year ago

Hi fsbraun and raffael-mnhn thanks to assign this task to me and thanks for the replay.

baravkareknath commented 1 year ago

Hi fsbraun and raffael, same issue gets in https://github.com/django-cms/djangocms-picture.git so can I resolve this issue in djangocms-picture.git repository?

fsbraun commented 1 year ago

@baravkareknath You can do both. Chose one place to start and after finishing start the second. There's already alignment options which according to https://getbootstrap.com/docs/5.3/content/images/#aligning-images should be turned into float classes.

baravkareknath commented 1 year ago

Hi fsbraun I am creating patch for repository - https://github.com/django-cms/djangocms-picture.git
so can I submit it for review purpose.