search

django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.
Other
45 stars 20 forks source link

Attributes not being added to a heading #13

Closed marksweb closed 2 years ago

marksweb commented 2 years ago

The template uses instance.attributes_str but I'm not seeing my classes on a heading.

To Reproduce Steps to reproduce the behavior:

  1. Create a heading plugin
  2. Click on advanced settings and add classes
  3. Save the plugin
  4. No classes seen on heading

Expected behavior I'm expecting the heading to render with my classes.

Screenshots Screenshot 2022-03-19 at 23 20 09

Additional context The two headings seen in the above image are copies of one-another. The first was created as a child of another element. Then I created a copy to verify it wasn't somehow related to it being a child.

fsbraun commented 2 years ago

Fixed by https://github.com/fsbraun/djangocms-frontend/commit/bf15bd33dcadc8eb1891e261b08a2db7cbd15fa6 ! Thanks! It actually was a missing update in the template leading to attributes not being rendered.