django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.
Other
43 stars 20 forks source link

Use `bg-body` for tab navigation #138

Closed stefanw closed 1 year ago

stefanw commented 1 year ago

In order to support Bootstrap color modes bg-white should be avoided.

codecov[bot] commented 1 year ago

Codecov Report

Merging #138 (4629b25) into master (3f88d49) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files         119      119           
  Lines        3086     3086           
  Branches      329      329           
=======================================
  Hits         2679     2679           
  Misses        300      300           
  Partials      107      107           
Impacted Files Coverage Δ
...cms_frontend/contrib/tabs/frameworks/bootstrap5.py 50.00% <100.00%> (ø)
fsbraun commented 1 year ago

@stefanw Thank you very much for the PR. Can you quickly add a note in the changelog?

fsbraun commented 1 year ago

Thank you!