django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.
Other
48 stars 21 forks source link

fix: Set proper image target link in template #146

Closed corentinbettiol closed 1 year ago

corentinbettiol commented 1 year ago

We saw that even when selecting the "open in a new window" (or tab) option, the template was not displaying the target="_blank" attribute in the link of an image plugin.

That's because the template is using instance.link_target instead of instance.target, so I fixed that in the template :)

codecov[bot] commented 1 year ago

Codecov Report

Merging #146 (733661c) into master (b4e8536) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files         119      119           
  Lines        3087     3087           
  Branches      329      329           
=======================================
  Hits         2680     2680           
  Misses        300      300           
  Partials      107      107           
fsbraun commented 1 year ago

@corentinbettiol Well spotted! Can you also update the change log?

corentinbettiol commented 1 year ago

@fsbraun Sure, is this okay?