django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.
Other
48 stars 21 forks source link

fix: Allow empty icon (None) in icon tags #159

Closed fsbraun closed 11 months ago

codecov[bot] commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6794a6e) 86.88% compared to head (5a69dd9) 86.88%. Report is 1 commits behind head on master.

:exclamation: Current head 5a69dd9 differs from pull request most recent head 06c4a59. Consider uploading reports for the commit 06c4a59 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #159 +/- ## ======================================= Coverage 86.88% 86.88% ======================================= Files 119 119 Lines 3089 3089 Branches 329 329 ======================================= Hits 2684 2684 Misses 299 299 Partials 106 106 ``` | [Files](https://app.codecov.io/gh/django-cms/djangocms-frontend/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms) | Coverage Δ | | |---|---|---| | [...ms\_frontend/contrib/icon/templatetags/icon\_tags.py](https://app.codecov.io/gh/django-cms/djangocms-frontend/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms#diff-ZGphbmdvY21zX2Zyb250ZW5kL2NvbnRyaWIvaWNvbi90ZW1wbGF0ZXRhZ3MvaWNvbl90YWdzLnB5) | `76.92% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.