search

django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.
Other
43 stars 20 forks source link

Document licenses of vendored assets #166

Closed stefan6419846 closed 7 months ago

stefan6419846 commented 7 months ago

Is your feature request related to a problem? Please describe.

To ensure license compliance, all components need to be researched with their corresponding license details. This can be supported by the package maintainers by providing some corresponding documentation.

Describe the solution you'd like

Besides the base package license, the licenses of vendored code/assets should be present as well.

Describe alternatives you've considered

At the moment, I am manually researching the most likely source for each vendored asset.

Additional context

For now, I mostly stumbled upon the fonts in https://github.com/django-cms/djangocms-frontend/tree/master/djangocms_frontend/contrib/icon/static/djangocms_frontend/icon/vendor/assets/fonts. Some fonts might allow re-licensing under the package license (BSD-3-Clause), while the weather icons appear to be subject to the OFL-1.1 (https://github.com/erikflowers/weather-icons/), which disallows changing the license.

fsbraun commented 7 months ago

@stefan6419846 Thanks for raising this issue! Do I understand correctly that you awk for an overview of the vendor asset licences in the LICENSE file to avoid having users research the licences themselves?

stefan6419846 commented 7 months ago

Yes, this is correct - the license for the assets as well as their upstream URLs.

fsbraun commented 7 months ago

Would you mind quickly checking if #167 helps?

stefan6419846 commented 6 months ago

Looking at the generated wheel, it seems like this change has been incomplete? Apparently, https://github.com/django-cms/djangocms-frontend/tree/master/djangocms_frontend/contrib/icon/static/djangocms_frontend/icon/vendor/assets/icons-libraries and https://github.com/django-cms/djangocms-frontend/tree/master/djangocms_frontend/contrib/icon/static/djangocms_frontend/icon/vendor/assets/stylesheets still contain the entries for the removed fonts.