search

django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.
Other
42 stars 20 forks source link

fix: Use gettext_lazy for model verbose names #203

Closed tidenhub closed 2 months ago

tidenhub commented 2 months ago

Hi, model field verbose_names should use gettext_lazy, because it creates migrations based on user language settings.

manage.py makemigrations --dry-run
Migrations for 'djangocms_frontend':
  /home/x/lib/python3.9/site-packages/djangocms_frontend/migrations/0002_alter_frontenduiitem_options.py
    - Change Meta options on frontenduiitem
Migrations for 'listgroup':
  /home/x/lib/python3.9/site-packages/djangocms_frontend/contrib/listgroup/migrations/0002_alter_listgroup_options_alter_listgroupitem_options.py
    - Change Meta options on listgroup
    - Change Meta options on listgroupitem
Migrations for 'media':
  /home/x/lib/python3.9/site-packages/djangocms_frontend/contrib/media/migrations/0002_alter_media_options_alter_mediabody_options.py
    - Change Meta options on media
    - Change Meta options on mediabody
Migrations for 'tabs':
  /home/x/lib/python3.9/site-packages/djangocms_frontend/contrib/tabs/migrations/0002_alter_tab_options_alter_tabitem_options.py
    - Change Meta options on tab
    - Change Meta options on tabitem
Migrations for 'utilities':
  /home/x/lib/python3.9/site-packages/djangocms_frontend/contrib/utilities/migrations/0002_alter_heading_options_alter_spacing_options_and_more.py
    - Change Meta options on heading
    - Change Meta options on spacing
    - Change Meta options on tableofcontents
fsbraun commented 2 months ago

@tidenhub Can you fix the isort issue?

tidenhub commented 2 months ago

pre-commit.ci autofix

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.91%. Comparing base (f11feee) to head (b7527d6). Report is 13 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #203 +/- ## ========================================== - Coverage 86.93% 86.91% -0.02% ========================================== Files 120 120 Lines 3107 3119 +12 Branches 330 331 +1 ========================================== + Hits 2701 2711 +10 + Misses 304 303 -1 - Partials 102 105 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.