search

django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.
Other
42 stars 20 forks source link

fix: Move autocomplete view for links to admin #211

Closed fsbraun closed 2 months ago

fsbraun commented 2 months ago

This PR removes the need for registering its own autocomplete view by moving the autocomplete view to the Link plugin itself.

Note: The link plugin handles the autocomplete view also for other plugins using the LinkPluginMixin.

Expected to fix #209

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 80.76923% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 86.39%. Comparing base (f11feee) to head (d1392f3). Report is 18 commits behind head on master.

Files Patch % Lines
djangocms_frontend/contrib/grid/forms.py 0.00% 2 Missing :warning:
djangocms_frontend/contrib/link/forms.py 81.81% 2 Missing :warning:
djangocms_frontend/templatetags/frontend.py 0.00% 2 Missing :warning:
djangocms_frontend/common/title.py 0.00% 1 Missing :warning:
djangocms_frontend/contrib/carousel/models.py 0.00% 0 Missing and 1 partial :warning:
...ms_frontend/contrib/icon/templatetags/icon_tags.py 0.00% 1 Missing :warning:
djangocms_frontend/contrib/link/cms_plugins.py 85.71% 0 Missing and 1 partial :warning:
djangocms_frontend/contrib/link/helpers.py 0.00% 1 Missing :warning:
djangocms_frontend/contrib/link/models.py 0.00% 0 Missing and 1 partial :warning:
...angocms_frontend/contrib/navigation/cms_plugins.py 83.33% 1 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #211 +/- ## ========================================== - Coverage 86.93% 86.39% -0.54% ========================================== Files 120 119 -1 Lines 3107 3109 +2 Branches 330 332 +2 ========================================== - Hits 2701 2686 -15 - Misses 304 320 +16 - Partials 102 103 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.