search

django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.
Other
42 stars 20 forks source link

Update icon.html #222

Closed hgkornmann closed 1 week ago

hgkornmann commented 1 month ago

Update to solve bug #200

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.55%. Comparing base (f11feee) to head (9012143). Report is 28 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #222 +/- ## ========================================== - Coverage 86.93% 86.55% -0.38% ========================================== Files 120 119 -1 Lines 3107 3109 +2 Branches 330 332 +2 ========================================== - Hits 2701 2691 -10 - Misses 304 316 +12 Partials 102 102 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fsbraun commented 1 week ago

@hgkornmann Can you combine the two changes into one pull request, please?

hgkornmann commented 1 week ago

Hi,

could you please make it? I'm not very familiar with it yet.

Best regards

   

Gesendet: Dienstag, 18. Juni 2024 um 09:25 Uhr Von: "Fabian Braun" @.> An: "django-cms/djangocms-frontend" @.> Cc: "hgkornmann" @.>, "Mention" @.> Betreff: Re: [django-cms/djangocms-frontend] Update icon.html (PR #222)

 

@hgkornmann Can you combine the two changes into one pull request, please?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>