django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.

Other

43 stars 20 forks source link

fix: optional djangocms-icon dependency #36

Closed fsbraun closed 2 years ago

fsbraun commented 2 years ago

So far djangocms-frontend required djangocms-icon to be installed. This becomes a soft dependency: If not installed, djangocms-frontend will not offer icons as decorator for links. To install djangocms-icon with djangocms-frontend, the requirement djangocms-frontend[djangocms-icon] is introduced.

codecov[bot] commented 2 years ago

Codecov Report

Merging #36 (fc02295) into master (4e9101c) will decrease coverage by 0.02%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   81.65%   81.62%   -0.03%     
==========================================
  Files         128      128              
  Lines        3962     3968       +6     
  Branches      796      798       +2     
==========================================
+ Hits         3235     3239       +4     
- Misses        600      601       +1     
- Partials      127      128       +1

Impacted Files	Coverage Δ
djangocms_frontend/contrib/link/cms_plugins.py	`80.95% <50.00%> (+0.46%)`	:arrow_up:
djangocms_frontend/contrib/link/forms.py	`82.51% <66.66%> (-0.82%)`	:arrow_down:
djangocms_frontend/settings.py	`96.42% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e9101c...fc02295. Read the comment docs.