search

django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.
Other
43 stars 20 forks source link

Fix/minor bugs #37

Closed fsbraun closed 2 years ago

fsbraun commented 2 years ago

This PR fixes minor bugs largely with migration from djangocms-bootstrap4. Especially situations as described in #33 are now avoided. Migration output should be more meaningful. Clarifies #34 .

codecov[bot] commented 2 years ago

Codecov Report

Merging #37 (c6af565) into master (af81fd6) will decrease coverage by 0.00%. The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   81.65%   81.65%   -0.01%     
==========================================
  Files         128      128              
  Lines        3952     3962      +10     
  Branches      792      796       +4     
==========================================
+ Hits         3227     3235       +8     
  Misses        600      600              
- Partials      125      127       +2
Impacted Files Coverage Δ
djangocms_frontend/contrib/carousel/constants.py 100.00% <ø> (ø)
djangocms_frontend/contrib/link/cms_plugins.py 80.48% <50.00%> (-2.02%) :arrow_down:
djangocms_frontend/fields.py 85.71% <88.88%> (+0.24%) :arrow_up:
djangocms_frontend/contrib/carousel/forms.py 100.00% <100.00%> (ø)
djangocms_frontend/contrib/image/forms.py 93.84% <100.00%> (ø)
djangocms_frontend/contrib/jumbotron/forms.py 100.00% <100.00%> (ø)
djangocms_frontend/contrib/link/forms.py 83.33% <100.00%> (ø)
djangocms_frontend/contrib/navigation/forms.py 100.00% <100.00%> (ø)
djangocms_frontend/contrib/tabs/forms.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af81fd6...c6af565. Read the comment docs.