django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.
Other
43 stars 20 forks source link

fix: Allow for static ace editor files (through djangocms-static-ace) #49

Closed fsbraun closed 1 year ago

fsbraun commented 1 year ago

Description

This PR does

This fixes the corresponding bug mentioned here https://github.com/django-cms/djangocms-frontend/issues/48

Related resources

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #49 (308ee79) into master (b46bde5) will increase coverage by 5.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   81.60%   86.60%   +5.00%     
==========================================
  Files         128      110      -18     
  Lines        3974     2920    -1054     
  Branches      799      565     -234     
==========================================
- Hits         3243     2529     -714     
+ Misses        602      294     -308     
+ Partials      129       97      -32     
Impacted Files Coverage Δ
djangocms_frontend/contrib/image/cms_plugins.py 92.30% <ø> (ø)
djangocms_frontend/contrib/content/forms.py 100.00% <100.00%> (ø)
djangocms_frontend/helpers.py 86.95% <0.00%> (-5.80%) :arrow_down:
djangocms_frontend/contrib/link/forms.py 76.92% <0.00%> (-5.60%) :arrow_down:
djangocms_frontend/fields.py 81.74% <0.00%> (-3.97%) :arrow_down:
djangocms_frontend/settings.py 92.85% <0.00%> (-3.58%) :arrow_down:
djangocms_frontend/models.py 81.96% <0.00%> (-3.28%) :arrow_down:
djangocms_frontend/contrib/link/cms_plugins.py 78.57% <0.00%> (-2.39%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

lgtm-com[bot] commented 1 year ago

This pull request fixes 8 alerts when merging f71f53ab2e3f8c1b11b86bd24e28692b5619bdc4 into b46bde56b10e365629983525cdfa7508fec0cb8c - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 2 alerts and fixes 8 when merging 308ee7907360448d237f47331d7a340be4cac76a into b46bde56b10e365629983525cdfa7508fec0cb8c - view on LGTM.com

new alerts:

fixed alerts: