django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.
Other
43 stars 20 forks source link

Top-level Accordion <div> is missing the `accordion` class #51

Closed greyhare closed 1 year ago

greyhare commented 1 year ago

Describe the bug The accordion plugin looked wonky, so I looked at the DOM and compared it to the Bootstrap docs, and didn't see the accordion class applied to the top-level <div>. Adding it manually in the browser debug pane made it look right.

To Reproduce Steps to reproduce the behavior:

  1. Add an Accordion element to a page.
  2. Add some boilerplate to the tags.
  3. See below.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots What it looks like: acc-wo-styling code-wo-accordion-class

What it should look like: acc-with-styling code-with-accordion-class

Desktop (please complete the following information):

greyhare commented 1 year ago

Accordion element was created with:

greyhare commented 1 year ago

Checking "Integrate into parent" properly adds the accordion-flush class but the accordion class is still missing.

fsbraun commented 1 year ago

@greyhare Again well spotted! Thanks very much for pointing this out!

PR is coming up!

greyhare commented 1 year ago

I've been putting together a page with all the frontend plugins for documentation and demonstration purposes, so I've been running into these.

fsbraun commented 1 year ago

That sounds interesting! Do you think this page or screenshots of it would be sharable, e.g. in the docs?

greyhare commented 1 year ago

It'll be too big for a screenshot, but I should have a plugins.json I can upload.

It's been slow going, so don't hold your breath.

fsbraun commented 1 year ago

Solved with #53