search

django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.
Other
43 stars 20 forks source link

fix: Missing accordion class #53

Closed fsbraun closed 1 year ago

fsbraun commented 1 year ago

This PR fixes two issues: #51 (missing accordion class in top-level accordion div) and #52 (Missing bundle.utilities.js)

While #51 breaks accordion styling, #52 "only" has the effect of the browser requesting a non-existent file bundle.utilities.js.

The functionality of bundle.utilities.js has been moved into the repo's css a while ago but two references were not deleted.

Thanks to @greyhare for identifying those two issues!

codecov[bot] commented 1 year ago

Codecov Report

Merging #53 (2ed8a7c) into master (5da4257) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   86.60%   86.61%           
=======================================
  Files         110      110           
  Lines        2920     2921    +1     
  Branches      565      565           
=======================================
+ Hits         2529     2530    +1     
  Misses        294      294           
  Partials       97       97
Impacted Files Coverage Δ
...rontend/contrib/accordion/frameworks/bootstrap5.py 73.33% <100.00%> (+1.90%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.