search

django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.
Other
43 stars 20 forks source link

fix: Image plugin linked to deleted ``filer.Image`` object. #59

Closed marksweb closed 1 year ago

marksweb commented 1 year ago

This fixes issue where an Image plugin is linked to a filer.Image object which has been deleted.

The result of this change is that instead of the page throwing a 500 error on the ValueError from easy_thumbnails, you get "file is missing" in the structure pane and the field appears empty in the form.

Screenshot 2022-09-14 at 14 54 22

codecov[bot] commented 1 year ago

Codecov Report

Merging #59 (309194f) into master (29019a7) will decrease coverage by 0.16%. The diff coverage is 68.42%.

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   86.62%   86.46%   -0.17%     
==========================================
  Files         110      110              
  Lines        2924     2933       +9     
  Branches      565      565              
==========================================
+ Hits         2533     2536       +3     
- Misses        294      300       +6     
  Partials       97       97
Impacted Files Coverage Δ
djangocms_frontend/contrib/image/models.py 67.39% <68.42%> (-3.70%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.