fix: navigation template to get correct menu display

[rolandf]

Small change to fix navigation plugin menu.

[fsbraun]

@rolandf Can you check why the tests fail?

[rolandf]

Sorry I don't understand how changing just two html tags in a template generate so much errors. My TemplateFix branch was created from a point in time where frontend_form was still in djangocms_frontend, not from the latest branch. Is that the reason ?

[fsbraun]

I think the unit test for navigation has to be adapted to the new template. This unit test fails for all this cases of course. Can you look at the test for navigation? Thank you so much!

[marksweb]

@rolandf having a quick look at the change vs the failure message, the test expects an empty div with a class of container. Following this change I think what it's getting is the container div with the ul tag inside.

[rolandf]

Sorry but I don't get it. I did manage.py test and no errors come up.

[fsbraun]

Sorry, it's python run_tests.py in the package directory (../ djangocms-frontend).

[rolandf]

@fsbraun Thank you for the head up. I made an update to the test on my branch. I see a mention of that in this pull request, is that all or is there a new action needed from me to have github relaunch tests and see if they pass ?

[codecov[bot]]

Codecov Report

Merging #64 (945ad84) into master (35efb2e) will increase coverage by 0.32%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   86.44%   86.77%   +0.32%     
==========================================
  Files         105      105              
  Lines        2774     2774              
  Branches      542      542              
==========================================
+ Hits         2398     2407       +9     
+ Misses        285      278       -7     
+ Partials       91       89       -2     

Impacted Files	Coverage Δ
djangocms_frontend/contrib/link/cms_plugins.py	80.95% <0.00%> (+2.38%)	:arrow_up:
djangocms_frontend/contrib/link/forms.py	82.51% <0.00%> (+5.59%)	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.