Closed fsbraun closed 1 year ago
Merging #68 (6a1db04) into master (a03e04d) will increase coverage by
0.37%
. The diff coverage is84.21%
.
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 86.06% 86.44% +0.37%
==========================================
Files 105 105
Lines 2798 2810 +12
Branches 288 285 -3
==========================================
+ Hits 2408 2429 +21
+ Misses 294 290 -4
+ Partials 96 91 -5
Impacted Files | Coverage Δ | |
---|---|---|
djangocms_frontend/contrib/link/cms_plugins.py | 80.95% <ø> (+2.38%) |
:arrow_up: |
djangocms_frontend/common/background.py | 54.54% <83.33%> (+25.97%) |
:arrow_up: |
djangocms_frontend/common/responsive.py | 54.54% <83.33%> (+25.97%) |
:arrow_up: |
djangocms_frontend/common/sizing.py | 54.54% <83.33%> (+25.97%) |
:arrow_up: |
djangocms_frontend/contrib/grid/forms.py | 90.90% <100.00%> (ø) |
|
djangocms_frontend/contrib/link/forms.py | 82.51% <0.00%> (+5.59%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
This pull request fixes 1 alert when merging d800005a8c79dde3695a06c4f817d477da459365 into 00220e0fe605ca41f04cf3b4195eb35ab190e669 - view on LGTM.com
fixed alerts:
This pull request fixes 7 alerts when merging a96c542cdafe80b9844cafb1b5fc39f34d3406a6 into 00220e0fe605ca41f04cf3b4195eb35ab190e669 - view on LGTM.com
fixed alerts:
This pull request fixes 7 alerts when merging 00294e2100a7c32df021259129fe593d8da9127f into a03e04d8222ce5f11176019edf0cf16e9b305b40 - view on LGTM.com
fixed alerts:
This pull request fixes 7 alerts when merging 7dba0d52c2a8f9c6476a3cc7f1dc7fe40ebf3afd into a03e04d8222ce5f11176019edf0cf16e9b305b40 - view on LGTM.com
fixed alerts:
This pull request fixes 7 alerts when merging d1103a4fa57d5d2ef888c54a1410ed9c9d12ce26 into a03e04d8222ce5f11176019edf0cf16e9b305b40 - view on LGTM.com
fixed alerts:
This pull request fixes 7 alerts when merging 3877f16a3a0082295c41510e0a4d0dbe77df6b5f into a03e04d8222ce5f11176019edf0cf16e9b305b40 - view on LGTM.com
fixed alerts:
This pull request fixes 7 alerts when merging b1528f3212ef74feb5dbd675caee5a0d30ec8c4b into a03e04d8222ce5f11176019edf0cf16e9b305b40 - view on LGTM.com
fixed alerts:
This pull request fixes 6 alerts when merging 6a1db04fd8c8c4c8a97339b5ccaa46b0f3eb596e into a03e04d8222ce5f11176019edf0cf16e9b305b40 - view on LGTM.com
fixed alerts:
Looking good @fsbraun
Is that background stuff related to background images that we talked about recently?
Reading a doc string in this made me think it'd be good to type hint this.
I've also got a script that can compile the many requirements files for testing and include the hashes for each package using pip-tools. That may be something to look at to ease maintainence
Thanks, @marksweb ! I'm afraid that the background stuff is just tiding up the code. I will update your PR with the background image fixes for the docs.
For django CMS we're very far away from type hinting. I've not started experimenting with it yet. The biggest benefit seems to me that it documents expected types. PyCharm so far only confuses me if I have type hints in a project. Probably it guesses incorrectly.
The django-cms 4 test fails since django cms 4 is not yet Python 3.10 ready.